Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 981343002: Add md_settings to WATCHLISTS for c/b/resources/settings. (Closed)

Created:
5 years, 9 months ago by Oren Blasberg
Modified:
5 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add md_settings to WATCHLISTS for c/b/resources/settings. BUG= Committed: https://crrev.com/42e83d201c43395da01b63ed8569dbe16d5b4dfe Cr-Commit-Position: refs/heads/master@{#319544}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M WATCHLISTS View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Oren Blasberg
5 years, 9 months ago (2015-03-06 19:38:38 UTC) #2
stevenjb
https://codereview.chromium.org/981343002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/981343002/diff/1/WATCHLISTS#newcode435 WATCHLISTS:435: 'chrome/browser/resources/md_settings/'\ We need a | here. I would put ...
5 years, 9 months ago (2015-03-06 21:41:47 UTC) #3
Oren Blasberg
https://codereview.chromium.org/981343002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/981343002/diff/1/WATCHLISTS#newcode435 WATCHLISTS:435: 'chrome/browser/resources/md_settings/'\ On 2015/03/06 21:41:47, stevenjb wrote: > We need ...
5 years, 9 months ago (2015-03-06 21:44:41 UTC) #4
stevenjb
lgtm
5 years, 9 months ago (2015-03-06 23:54:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981343002/20001
5 years, 9 months ago (2015-03-07 00:01:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-07 02:05:25 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 02:05:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42e83d201c43395da01b63ed8569dbe16d5b4dfe
Cr-Commit-Position: refs/heads/master@{#319544}

Powered by Google App Engine
This is Rietveld 408576698