Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 981333002: win: Default build to x64 (Closed)

Created:
5 years, 9 months ago by scottmg
Modified:
5 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

win: Default build to x64 For Windows Crashpad's purposes at the moment, an x64 build is more useful so we can test cross-bitness access. We'll probably need to support an x86 build at some point for x86 host OS, but that can wait until some time in the future as we'll need to get x86 OS bots and fiddle with the waterfall configurations. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/8773bfd3a0006ee8795b296b6f772e08b7d518c5

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M build/common.gypi View 1 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 9 months ago (2015-03-06 20:04:07 UTC) #1
Mark Mentovai
LGTM
5 years, 9 months ago (2015-03-06 23:42:38 UTC) #2
scottmg
5 years, 9 months ago (2015-03-07 00:06:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8773bfd3a0006ee8795b296b6f772e08b7d518c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698