Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 981323002: Refactoring chromoting_jni_onload.cc (Closed)

Created:
5 years, 9 months ago by michaelbai
Modified:
5 years, 9 months ago
Reviewers:
Lambros
CC:
chromium-reviews, android-webview-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring chromoting_jni_onload.cc Make it using base::android::OnJNIOnLoadRegister(). BUG=447393 Committed: https://crrev.com/935810076bc8ee5ee110dd42b4c778768663380b Cr-Commit-Position: refs/heads/master@{#319556}

Patch Set 1 : #

Patch Set 2 : rebase and call base::android::OnJNIOnLoadInit #

Patch Set 3 : Remove the at_exit_manager and add back base::android::Register #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M remoting/client/jni/chromoting_jni_onload.cc View 1 2 2 chunks +21 lines, -18 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
michaelbai
Rebased and calling base::android::OnJNIOnLoadInit(), then your change is not necessary.
5 years, 9 months ago (2015-03-06 20:51:24 UTC) #3
Lambros
lgtm - I tested the latest patch with a few connect/disconnect cycles and all seems ...
5 years, 9 months ago (2015-03-06 23:05:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981323002/60001
5 years, 9 months ago (2015-03-07 00:30:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 02:32:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981323002/60001
5 years, 9 months ago (2015-03-07 05:55:03 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-07 05:55:49 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 05:56:22 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/935810076bc8ee5ee110dd42b4c778768663380b
Cr-Commit-Position: refs/heads/master@{#319556}

Powered by Google App Engine
This is Rietveld 408576698