Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 981293003: Autofill - Add tooltip icon to cvc verification dialog. (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill - Add tooltip icon to cvc verification dialog. Also fix position of bubble for requestAutocomplete dialog. BUG=464640 Committed: https://crrev.com/1a64f1ce6246785c3b5c02fc6e36a9de4157d180 Cr-Commit-Position: refs/heads/master@{#319687}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix bad rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/tooltip_icon.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/tooltip_icon.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
Evan Stade
5 years, 9 months ago (2015-03-06 23:19:14 UTC) #2
please use gerrit instead
lgtm
5 years, 9 months ago (2015-03-06 23:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981293003/1
5 years, 9 months ago (2015-03-07 00:19:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 02:21:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981293003/1
5 years, 9 months ago (2015-03-07 04:13:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-07 06:13:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981293003/1
5 years, 9 months ago (2015-03-08 01:20:42 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/app/generated_resources.grd: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-08 03:54:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981293003/20001
5 years, 9 months ago (2015-03-09 17:02:15 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/3517) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-09 17:08:12 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981293003/40001
5 years, 9 months ago (2015-03-09 17:19:47 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 18:15:13 UTC) #25
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:18:58 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a64f1ce6246785c3b5c02fc6e36a9de4157d180
Cr-Commit-Position: refs/heads/master@{#319687}

Powered by Google App Engine
This is Rietveld 408576698