Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 981293002: Re-enable Android profiling helper unittests (Closed)

Created:
5 years, 9 months ago by Sami
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable Android profiling helper unittests These seem to be passing locally now. BUG=437081 Committed: https://crrev.com/49fdcead2be3fb974069fe8b70651e6b26ba9455 Cr-Commit-Position: refs/heads/master@{#319471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sami
I can haz rubber stampy?
5 years, 9 months ago (2015-03-06 17:22:53 UTC) #2
Primiano Tucci (use gerrit)
Don't know, I don't have the magic tool :P caoutchouc-stamp-LGTM
5 years, 9 months ago (2015-03-06 17:31:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981293002/1
5 years, 9 months ago (2015-03-06 18:36:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 19:10:24 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49fdcead2be3fb974069fe8b70651e6b26ba9455 Cr-Commit-Position: refs/heads/master@{#319471}
5 years, 9 months ago (2015-03-06 19:11:04 UTC) #7
Sami
5 years, 9 months ago (2015-03-09 15:26:25 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/988403002/ by skyostil@chromium.org.

The reason for reverting is: Still failing on the FYI bot:
http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28K%20N5....

Powered by Google App Engine
This is Rietveld 408576698