Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 981243006: Upstream an initial implementation of Tab.getProgress. (Closed)

Created:
5 years, 9 months ago by Yaron
Modified:
5 years, 9 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream an initial implementation of Tab.getProgress. Includes some related loading status changes. BUG=443773 Committed: https://crrev.com/e9652a2e186fe5dd8cdf19ce3b7faafdfbc9b1d9 Cr-Commit-Position: refs/heads/master@{#319625}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 2 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yaron
5 years, 9 months ago (2015-03-06 22:34:10 UTC) #2
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/981243006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://chromiumcodereview.appspot.com/981243006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1013 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1013: public int getProgress() { Javadoc
5 years, 9 months ago (2015-03-06 22:39:21 UTC) #3
Yaron
https://chromiumcodereview.appspot.com/981243006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://chromiumcodereview.appspot.com/981243006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1013 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1013: public int getProgress() { On 2015/03/06 22:39:21, David Trainor ...
5 years, 9 months ago (2015-03-06 23:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981243006/40001
5 years, 9 months ago (2015-03-09 13:35:34 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 13:59:39 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 14:00:26 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e9652a2e186fe5dd8cdf19ce3b7faafdfbc9b1d9
Cr-Commit-Position: refs/heads/master@{#319625}

Powered by Google App Engine
This is Rietveld 408576698