Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/browser/resources/security_warnings/safe_browsing.js

Issue 981243003: Make commands consistent across security interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: if -> switch in SafeBrowsingBlockingPage Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/security_warnings/safe_browsing.js
diff --git a/chrome/browser/resources/security_warnings/safe_browsing.js b/chrome/browser/resources/security_warnings/safe_browsing.js
index 3673da5ceefcc616a57118fa3d285c562b05d3a0..1fa4555072bf762805b16ea5741bfcd6846582f3 100644
--- a/chrome/browser/resources/security_warnings/safe_browsing.js
+++ b/chrome/browser/resources/security_warnings/safe_browsing.js
@@ -2,16 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Must match the commands handled by SafeBrowsingBlockingPage::CommandReceived.
-var SB_CMD_DO_REPORT = 'doReport';
-var SB_CMD_DONT_REPORT = 'dontReport';
-var SB_CMD_EXPANDED_SEE_MORE = 'expandedSeeMore';
-var SB_CMD_LEARN_MORE_2 = 'learnMore2';
-var SB_CMD_PROCEED = 'proceed';
-var SB_CMD_SHOW_DIAGNOSTIC = 'showDiagnostic';
-var SB_CMD_SHOW_PRIVACY = 'showPrivacy';
-var SB_CMD_TAKE_ME_BACK = 'takeMeBack';
-
// Other constants defined in safe_browsing_blocking_page.cc.
var SB_BOX_CHECKED = 'boxchecked';
var SB_DISPLAY_CHECK_BOX = 'displaycheckbox';
@@ -30,6 +20,6 @@ function setupCheckbox() {
$('opt-in-checkbox').addEventListener('click', function() {
sendCommand(
- $('opt-in-checkbox').checked ? SB_CMD_DO_REPORT : SB_CMD_DONT_REPORT);
+ $('opt-in-checkbox').checked ? CMD_DO_REPORT : CMD_DONT_REPORT);
});
}

Powered by Google App Engine
This is Rietveld 408576698