Make commands consistent across security interstitials

chrome/browser/interstitials/security_interstitial_page.h

Index: chrome/browser/interstitials/security_interstitial_page.h
diff --git a/chrome/browser/interstitials/security_interstitial_page.h b/chrome/browser/interstitials/security_interstitial_page.h
index 98e8e197eeb6f766f42631fe9c890f1764e0ca36..44f2ad8ecfbcaf2ca6eba2dee959f9bb37984fa2 100644
--- a/chrome/browser/interstitials/security_interstitial_page.h
+++ b/chrome/browser/interstitials/security_interstitial_page.h
@@ -20,6 +20,27 @@ class WebContents;
 
 class SecurityInterstitialPage : public content::InterstitialPageDelegate {
  public:
+  // These represent the commands sent from the interstitial JavaScript.
+  // DO NOT reorder or change these without also changing the JavaScript!
+  // See chrome/browser/resources/security_warnings/interstitial_v2.js
+  enum SecurityInterstitialCommands {

[Bernhard Bauer, 2015/03/11 08:42:14]

Can you make this private?

[felt, 2015/03/11 15:25:09]

The tests (for the subclasses) use it. I'd have to friend them on this class so
that they can access it. That seems undesirable to me. Given that, do you have a
strong opinion?

[Bernhard Bauer, 2015/03/11 16:19:20]

Oh, right! Okay then, fair enough.

+    // Decisions
+    CMD_DONT_PROCEED = 0,
+    CMD_PROCEED = 1,
+    // Ways for user to get more information
+    CMD_SHOW_MORE_SECTION = 2,
+    CMD_OPEN_HELP_CENTER = 3,
+    CMD_OPEN_DIAGNOSTIC = 4,
+    // Primary button actions
+    CMD_RELOAD = 5,
+    CMD_OPEN_DATE_SETTINGS = 6,
+    CMD_OPEN_LOGIN = 7,
+    // Safe Browsing Extended Reporting
+    CMD_DO_REPORT = 8,
+    CMD_DONT_REPORT = 9,
+    CMD_OPEN_REPORTING_PRIVACY = 10,
+  };
+
   SecurityInterstitialPage(content::WebContents* web_contents,
                            const GURL& url);
   ~SecurityInterstitialPage() override;