Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: chrome/browser/resources/security_warnings/safe_browsing.js

Issue 981243003: Make commands consistent across security interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: if -> switch in SafeBrowsingBlockingPage Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Must match the commands handled by SafeBrowsingBlockingPage::CommandReceived.
6 var SB_CMD_DO_REPORT = 'doReport';
7 var SB_CMD_DONT_REPORT = 'dontReport';
8 var SB_CMD_EXPANDED_SEE_MORE = 'expandedSeeMore';
9 var SB_CMD_LEARN_MORE_2 = 'learnMore2';
10 var SB_CMD_PROCEED = 'proceed';
11 var SB_CMD_SHOW_DIAGNOSTIC = 'showDiagnostic';
12 var SB_CMD_SHOW_PRIVACY = 'showPrivacy';
13 var SB_CMD_TAKE_ME_BACK = 'takeMeBack';
14
15 // Other constants defined in safe_browsing_blocking_page.cc. 5 // Other constants defined in safe_browsing_blocking_page.cc.
16 var SB_BOX_CHECKED = 'boxchecked'; 6 var SB_BOX_CHECKED = 'boxchecked';
17 var SB_DISPLAY_CHECK_BOX = 'displaycheckbox'; 7 var SB_DISPLAY_CHECK_BOX = 'displaycheckbox';
18 8
19 // This sets up the Extended Safe Browsing Reporting opt-in. 9 // This sets up the Extended Safe Browsing Reporting opt-in.
20 function setupCheckbox() { 10 function setupCheckbox() {
21 if (loadTimeData.getString('type') != 'SAFEBROWSING' || 11 if (loadTimeData.getString('type') != 'SAFEBROWSING' ||
22 !loadTimeData.getBoolean(SB_DISPLAY_CHECK_BOX)) { 12 !loadTimeData.getBoolean(SB_DISPLAY_CHECK_BOX)) {
23 return; 13 return;
24 } 14 }
25 15
26 $('opt-in-label').innerHTML = loadTimeData.getString('optInLink'); 16 $('opt-in-label').innerHTML = loadTimeData.getString('optInLink');
27 $('opt-in-checkbox').checked = loadTimeData.getBoolean(SB_BOX_CHECKED); 17 $('opt-in-checkbox').checked = loadTimeData.getBoolean(SB_BOX_CHECKED);
28 $('malware-opt-in').classList.remove('hidden'); 18 $('malware-opt-in').classList.remove('hidden');
29 $('body').classList.add('safe-browsing-has-checkbox'); 19 $('body').classList.add('safe-browsing-has-checkbox');
30 20
31 $('opt-in-checkbox').addEventListener('click', function() { 21 $('opt-in-checkbox').addEventListener('click', function() {
32 sendCommand( 22 sendCommand(
33 $('opt-in-checkbox').checked ? SB_CMD_DO_REPORT : SB_CMD_DONT_REPORT); 23 $('opt-in-checkbox').checked ? CMD_DO_REPORT : CMD_DONT_REPORT);
34 }); 24 });
35 } 25 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698