Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 981243002: [turbofan] Introduce JSStackCheck operator. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce JSStackCheck operator. The key idea here is that the stack check should be explicit, such that we can eliminate unnecessary stack checks after graph building and potentially inlining. R=mstarzinger@chromium.org Committed: https://crrev.com/3c4a32dcdc8ca054130789cb2062a22b3e09071c Cr-Commit-Position: refs/heads/master@{#27056}

Patch Set 1 #

Patch Set 2 : REBASE #

Total comments: 4

Patch Set 3 : REBASE #

Patch Set 4 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -21 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 2 chunks +1 line, -16 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-06 13:50:51 UTC) #2
Michael Starzinger
LGTM with comments. https://codereview.chromium.org/981243002/diff/20001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/981243002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2969 src/compiler/ast-graph-builder.cc:2969: return NewNode(javascript()->StackCheck()); nit: I think we ...
5 years, 9 months ago (2015-03-06 14:06:40 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/981243002/diff/20001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/981243002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2969 src/compiler/ast-graph-builder.cc:2969: return NewNode(javascript()->StackCheck()); Indeed. https://codereview.chromium.org/981243002/diff/20001/src/compiler/js-generic-lowering.h File src/compiler/js-generic-lowering.h (right): https://codereview.chromium.org/981243002/diff/20001/src/compiler/js-generic-lowering.h#newcode54 src/compiler/js-generic-lowering.h:54: ...
5 years, 9 months ago (2015-03-09 05:01:46 UTC) #4
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3c4a32dcdc8ca054130789cb2062a22b3e09071c Cr-Commit-Position: refs/heads/master@{#27056}
5 years, 9 months ago (2015-03-09 05:02:19 UTC) #5
Benedikt Meurer
5 years, 9 months ago (2015-03-09 05:02:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
3c4a32dcdc8ca054130789cb2062a22b3e09071c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698