Add test for ProcessSingleton hung rendezvous case.

chrome/browser/process_singleton_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/process_singleton.h"
 
 #include <shellapi.h>
 
 #include "base/base_paths.h"
 #include "base/bind.h"
@@ skipping 177 matching lines @@
 // Move this function to a common place as the Windows 8 delegate_execute
 // handler can possibly use this.
 bool ShouldLaunchInWindows8ImmersiveMode(const base::FilePath& user_data_dir) {
   // Returning false from this function doesn't mean we don't launch immersive
   // mode in Aura. This function is specifically called in case when we need
   // to relaunch desktop launched chrome into immersive mode through 'relaunch'
   // menu. In case of Aura, we will use delegate_execute to do the relaunch.
   return false;
 }
 
+bool DisplayShouldKillMessageBox() {
+  return
+      chrome::ShowMessageBox(
+          NULL,
+          l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
+          l10n_util::GetStringUTF16(IDS_BROWSER_HUNGBROWSER_MESSAGE),
+          chrome::MESSAGE_BOX_TYPE_QUESTION) != chrome::MESSAGE_BOX_RESULT_NO;
+}
+
 }  // namespace
 
 // Microsoft's Softricity virtualization breaks the sandbox processes.
 // So, if we detect the Softricity DLL we use WMI Win32_Process.Create to
 // break out of the virtualization environment.
 // http://code.google.com/p/chromium/issues/detail?id=43650
 bool ProcessSingleton::EscapeVirtualization(
     const base::FilePath& user_data_dir) {
   if (::GetModuleHandle(L"sftldr_wow64.dll") ||
       ::GetModuleHandle(L"sftldr.dll")) {
@@ skipping 18 matching lines @@
     return true;
   }
   return false;
 }
 
 ProcessSingleton::ProcessSingleton(
     const base::FilePath& user_data_dir,
     const NotificationCallback& notification_callback)
     : notification_callback_(notification_callback),
       is_virtualized_(false), lock_file_(INVALID_HANDLE_VALUE),
-      user_data_dir_(user_data_dir) {
+      user_data_dir_(user_data_dir),
+      display_should_kill_messagebox_callback_(
+          base::Bind(&DisplayShouldKillMessageBox)) {
 }
 
 ProcessSingleton::~ProcessSingleton() {
   if (lock_file_ != INVALID_HANDLE_VALUE)
     ::CloseHandle(lock_file_);
 }
 
 // Code roughly based on Mozilla.
 ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcess() {
   if (is_virtualized_)
@@ skipping 25 matching lines @@
   }
   base::Process process = base::Process::Open(process_id);
 
   // The window is hung. Scan for every window to find a visible one.
   bool visible_window = false;
   ::EnumThreadWindows(thread_id,
                       &BrowserWindowEnumeration,
                       reinterpret_cast<LPARAM>(&visible_window));
 
   // If there is a visible browser window, ask the user before killing it.
-  if (visible_window &&
-      chrome::ShowMessageBox(
-          NULL,
-          l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
-          l10n_util::GetStringUTF16(IDS_BROWSER_HUNGBROWSER_MESSAGE),
-          chrome::MESSAGE_BOX_TYPE_QUESTION) == chrome::MESSAGE_BOX_RESULT_NO) {
+  if (visible_window && !display_should_kill_messagebox_callback_.Run()) {
     // The user denied. Quit silently.
     return PROCESS_NOTIFIED;
   }
 
   // Record the termination event in the hung process' exit funnel.
   browser_watcher::ExitFunnel funnel;
   if (funnel.Init(chrome::kBrowserExitCodesRegistryPath, process.Handle()))
     funnel.RecordEvent(L"HungBrowserTerminated");
 
   // Time to take action. Kill the browser process.
@@ skipping 132 matching lines @@
           ::SetEvent(metro_activation_event.Get());
       }
     }
   }
 
   return window_.hwnd() != NULL;
 }
 
 void ProcessSingleton::Cleanup() {
 }
+
+void  ProcessSingleton::OverrideKillMessageBoxCallbackForTesting(

[erikwright (departed), 2015/03/10 19:22:49]

extra space after void

[Sigurður Ásgeirsson, 2015/03/10 19:48:15]

Done.

+    const DisplayShouldKillMessageBoxCallback& display_dialog_callback) {
+  display_should_kill_messagebox_callback_ = display_dialog_callback;
+}