chrome/browser/chrome_process_finder_win.h - Issue 981223004: Add test for ProcessSingleton hung rendezvous case.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chrome_process_finder_win.h

Issue 981223004: Add test for ProcessSingleton hung rendezvous case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Gab's remaining comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/chrome_process_finder_win.cc » ('j') | chrome/browser/chrome_process_finder_win.cc » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_CHROME_PROCESS_FINDER_WIN_H_	5 #ifndef CHROME_BROWSER_CHROME_PROCESS_FINDER_WIN_H_

6 #define CHROME_BROWSER_CHROME_PROCESS_FINDER_WIN_H_	6 #define CHROME_BROWSER_CHROME_PROCESS_FINDER_WIN_H_

7	7

8 #include <windows.h>	8 #include <windows.h>

9	9

10 namespace base {	10 namespace base {

(...skipping 11 matching lines...) Expand all Loading...
22 // Finds an already running Chrome window if it exists.	22 // Finds an already running Chrome window if it exists.

23 HWND FindRunningChromeWindow(const base::FilePath& user_data_dir);	23 HWND FindRunningChromeWindow(const base::FilePath& user_data_dir);

24	24

25 // Attempts to send the current command line to an already running instance of	25 // Attempts to send the current command line to an already running instance of

26 // Chrome via a WM_COPYDATA message.	26 // Chrome via a WM_COPYDATA message.

27 // Returns true if a running Chrome is found and successfully notified.	27 // Returns true if a running Chrome is found and successfully notified.

28 // \|fast_start\| is true when this is being called on the window fast start path.	28 // \|fast_start\| is true when this is being called on the window fast start path.

29 NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window,	29 NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window,

30 bool fast_start);	30 bool fast_start);

31	31

	32 // Changes the notification timeout to \|new_timeout\|, returns the old timeout.

	33 int SetNotificationTimeoutInSecondsForTesting(int new_timeout);
	sky 2015/03/11 19:15:51 Make this take a TimeDelta so that units are clear Make this take a TimeDelta so that units are clearer and its less error prone. Sigurður Ásgeirsson 2015/03/11 20:15:31 Done. Show quoted text On 2015/03/11 19:15:51, sky wrote: > Make this take a TimeDelta so that units are clearer and its less error prone. Done.
	34

32 } // namespace chrome	35 } // namespace chrome

33	36

34 #endif // CHROME_BROWSER_CHROME_PROCESS_FINDER_WIN_H_	37 #endif // CHROME_BROWSER_CHROME_PROCESS_FINDER_WIN_H_

OLD	NEW