Add test for ProcessSingleton hung rendezvous case.

chrome/browser/chrome_process_finder_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_process_finder_win.h"
 
 #include <shellapi.h>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 10 matching lines @@
 #include "base/win/scoped_handle.h"
 #include "base/win/win_util.h"
 #include "base/win/windows_version.h"
 #include "chrome/browser/metro_utils/metro_chrome_win.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 
 
 namespace {
 
-const int kTimeoutInSeconds = 20;
+const int kDefaultTimeoutInSeconds = 20;

[sky, 2015/03/11 19:15:51]

There is no point in this constant now. Initialize g_timeout_in_seconds with 20
and nuke kDefault.

[Sigurður Ásgeirsson, 2015/03/11 20:15:31]

Done.

+
+int g_timeout_in_seconds = kDefaultTimeoutInSeconds;

[sky, 2015/03/11 19:15:51]

This isn't global, it's file local. It should be timeout_in_seconds.

[Sigurður Ásgeirsson, 2015/03/11 20:15:31]

Done.

[gab, 2015/03/11 20:25:35]

Interesting, I've seen g_ prefixes used for file local variables in chrome
before (i.e. 153 instances in anonymous namespaces in chrome/ alone [1])

FWIW, I like using g_ as it's a reading hint between a local variable (i.e.
local scope/on the stack) and a program-wide file local/global variable which
helps the reader/reviewer think of things like thread-safety, etc.

[1]
https://code.google.com/p/chromium/codesearch#search/&q=file:chrome/*%20pcre:...

Lastly, FWIW, the style-guide isn't very specific here beyond suggesting g_ for
globals:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Variable_Names

[sky, 2015/03/11 20:27:59]

I agree that g_foo is more readable, but it's my take that this isn't a global
so g_ isn't appropriate. You can ask for clarification on the style-guide alias
or chromium-dev.

 
 // The following is copied from net/base/escape.cc. We don't want to depend on
 // net here because this gets compiled into chrome.exe to facilitate
 // fast-rendezvous (see https://codereview.chromium.org/14617003/).
 
 // TODO(koz): Move these functions out of net/base/escape.cc into base/escape.cc
 // so we can depend on it directly.
 
 // BEGIN COPY from net/base/escape.cc
 
@@ skipping 92 matching lines @@
 
   // Allow the current running browser window to make itself the foreground
   // window (otherwise it will just flash in the taskbar).
   ::AllowSetForegroundWindow(process_id);
 
   COPYDATASTRUCT cds;
   cds.dwData = 0;
   cds.cbData = static_cast<DWORD>((to_send.length() + 1) * sizeof(wchar_t));
   cds.lpData = const_cast<wchar_t*>(to_send.c_str());
   DWORD_PTR result = 0;
-  if (::SendMessageTimeout(remote_window,
-                           WM_COPYDATA,
-                           NULL,
-                           reinterpret_cast<LPARAM>(&cds),
-                           SMTO_ABORTIFHUNG,
-                           kTimeoutInSeconds * 1000,
-                           &result)) {
+  if (::SendMessageTimeout(remote_window, WM_COPYDATA, NULL,
+                           reinterpret_cast<LPARAM>(&cds), SMTO_ABORTIFHUNG,
+                           g_timeout_in_seconds * 1000, &result)) {
     return result ? NOTIFY_SUCCESS : NOTIFY_FAILED;
   }
 
   // It is possible that the process owning this window may have died by now.
   if (!::IsWindow(remote_window))
     return NOTIFY_FAILED;
 
   // If the window couldn't be notified but still exists, assume it is hung.
   return NOTIFY_WINDOW_HUNG;
 }
 
+int SetNotificationTimeoutInSecondsForTesting(int new_timeout) {
+  int old_timeout = g_timeout_in_seconds;
+  g_timeout_in_seconds = new_timeout;
+  return old_timeout;
+}
+
 }  // namespace chrome