Do not include code objects for functions in the start-up snapshot.

Do not include code objects for functions in the start-up snapshot.

Committed: https://crrev.com/206303f7036798979f129e208cb811fc1e9dd8c1
Cr-Commit-Position: refs/heads/master@{#27047}

[Yang, 2015-03-06 13:02:11]

yangguo@chromium.org changed reviewers:
+ mstarzinger@chromium.org, verwaest@chromium.org

[Yang, 2015-03-06 13:02:11]

@mstarzinger please review the TF part of the change.

[Michael Starzinger, 2015-03-06 13:15:47]

LGTM on the TF part, didn't look at the rest.

https://codereview.chromium.org/981213002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (left):

https://codereview.chromium.org/981213002/diff/20001/src/bootstrapper.cc#oldc...
src/bootstrapper.cc:2613: // TODO(mstarzinger): This is just a temporary hack to
make TurboFan work,
Woot! Taking care of my TODOs like a boss, by reviewing other people's changes.
Thanks!

[Toon Verwaest, 2015-03-06 13:22:26]

lgtm, awesome

[Michael Starzinger, 2015-03-06 14:19:47]

One more nit (unless I am late to the party already).

https://codereview.chromium.org/981213002/diff/20001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/981213002/diff/20001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:11: #include "src/bootstrapper.h"  //
TODO(mstarzinger): Only temporary.
nit: Can we now drop this include again?

[Yang, 2015-03-06 14:25:50]

https://codereview.chromium.org/981213002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (left):

https://codereview.chromium.org/981213002/diff/20001/src/bootstrapper.cc#oldc...
src/bootstrapper.cc:2613: // TODO(mstarzinger): This is just a temporary hack to
make TurboFan work,
On 2015/03/06 13:15:47, Michael Starzinger wrote:
> Woot! Taking care of my TODOs like a boss, by reviewing other people's
changes.
> Thanks!

:)

https://codereview.chromium.org/981213002/diff/20001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/981213002/diff/20001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:11: #include "src/bootstrapper.h"  //
TODO(mstarzinger): Only temporary.
On 2015/03/06 14:19:47, Michael Starzinger wrote:
> nit: Can we now drop this include again?

Sure.

[Yang, 2015-03-06 14:51:09]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-06 14:51:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/981213002/#ps40001 (title:
"remove inlcude")

[commit-bot: I haz the power, 2015-03-06 14:52:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/981213002/40001

[commit-bot: I haz the power, 2015-03-06 15:06:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-06 15:07:21]

Patchset 3 (id:??) landed as
https://crrev.com/206303f7036798979f129e208cb811fc1e9dd8c1
Cr-Commit-Position: refs/heads/master@{#27047}