chrome/browser/resources/settings/settings_ui/settings_ui.html - Issue 981203007: Scaffold for MD-Settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_ui/settings_ui.html

Issue 981203007: Scaffold for MD-Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: some fixes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_menu/settings_menu.html ('K') | « chrome/browser/resources/settings/settings_ui/settings_ui.css ('k') | chrome/browser/resources/settings/settings_ui/settings_ui.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/core-drawer-panel/core-drawe r-panel.html">

	2 <link rel="import" href="chrome://md-settings/settings_drawer/settings_drawer.ht ml">

	3 <link rel="import" href="chrome://md-settings/settings_main/settings_main.html">

	4

	5 <polymer-element name="cr-settings-ui">

	6 <template>

	7 <link rel="stylesheet" href="settings_ui.css">

	8 <core-drawer-panel drawerWidth="280px">
	Jeremy Klein 2015/03/12 06:46:36 Just curious: How does the responsive design look Just curious: How does the responsive design look with a really small window? Is there a way to open and close the drawer easily? Oren Blasberg 2015/03/12 18:58:17 Could the drawerWidth=280 be styled via css? Could Could the drawerWidth=280 be styled via css? Could we put it in the settings_ui.css by piercing the cr-settings-ui's shadow dom with ::shadow and grabbing the core-drawer-panel on it. (again, if this is a Q that was already answered, I am sorry) michaelpg 2015/03/13 00:47:01 It's kind of silly and may not be the best approac Show quoted text On 2015/03/12 06:46:36, Jeremy Klein wrote: > Just curious: How does the responsive design look with a really small window? Is > there a way to open and close the drawer easily? It's kind of silly and may not be the best approach, but I don't want to play around with the specifics until the UI is approved. I added a core-icon-button to open the drawer when the window is small (clicking outside the drawer closes it). michaelpg 2015/03/13 00:47:01 Not that I can tell, it seems to be an attribute t Show quoted text On 2015/03/12 18:58:17, Oren Blasberg wrote: > Could the drawerWidth=280 be styled via css? Could we put it in the > settings_ui.css by piercing the cr-settings-ui's shadow dom with ::shadow and > grabbing the core-drawer-panel on it. > (again, if this is a Q that was already answered, I am sorry) Not that I can tell, it seems to be an attribute that the JS of core-drawer-panel uses. Jeremy Klein 2015/03/13 00:49:31 Yeah, that's fine with me. Show quoted text On 2015/03/13 00:47:01, michaelpg wrote: > On 2015/03/12 06:46:36, Jeremy Klein wrote: > > Just curious: How does the responsive design look with a really small window? > Is > > there a way to open and close the drawer easily? > > It's kind of silly and may not be the best approach, but I don't want to play > around with the specifics until the UI is approved. I added a core-icon-button > to open the drawer when the window is small (clicking outside the drawer closes > it). Yeah, that's fine with me.
	9 <cr-settings-drawer drawer id="drawer" pages="{{pages}}"

	10 selectedId="{{selectedPageId}}">

	11 </cr-settings-drawer>

	12 <cr-settings-main main pages="{{pages}}" prefs="{{prefs}}"

	13 selectedPageId="{{selectedPageId}}">

	14 </cr-settings-main>

	15 </core-drawer-panel>

	16 </template>

	17 <script src="settings_ui.js"></script>

	18 </polymer-element>

OLD	NEW