chrome/browser/resources/settings/settings_main/settings_main.html - Issue 981203007: Scaffold for MD-Settings.

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 981203007: Scaffold for MD-Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: some fixes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_main/settings_main.css ('K') | « chrome/browser/resources/settings/settings_main/settings_main.css ('k') | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | chrome/browser/resources/settings/settings_main/settings_main.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/core-animated-pages/core-ani mated-pages.html">

	3 <link rel="import" href="chrome://resources/polymer/core-transition/core-transit ion.html">

	4 <link rel="import" href="chrome://resources/polymer/paper-shadow/paper-shadow.ht ml">

	5

	6 <polymer-element name="cr-settings-main">

	7 <template>

	8 <link rel="stylesheet" href="settings_main.css">

	9 <div id="container">

	10 <paper-shadow>

	11 <core-animated-pages id="pages" selected="{{selectedPageId}}"
	Kyle Horimoto 2015/03/12 18:57:35 nit: Do you think it would be better to give this nit: Do you think it would be better to give this an ID of "page-selector", or something a little different from the "pages" field used by most of the custom elements you create in this CL? michaelpg 2015/03/13 00:47:01 Good idea. I used 'pageContainer'. Show quoted text On 2015/03/12 18:57:35, Kyle Horimoto wrote: > nit: Do you think it would be better to give this an ID of "page-selector", or > something a little different from the "pages" field used by most of the custom > elements you create in this CL? Good idea. I used 'pageContainer'.
	12 valueattr="PAGE_ID" transitions="cross-fade">
	Jeremy Klein 2015/03/12 06:46:36 For the cross-fade, are you just thinking we'll ad For the cross-fade, are you just thinking we'll add the cross fade on elements inside the pages where appropriate? michaelpg 2015/03/13 00:47:01 No, we'll wrap the entire page in a <section cross Show quoted text On 2015/03/12 06:46:36, Jeremy Klein wrote: > For the cross-fade, are you just thinking we'll add the cross fade on elements > inside the pages where appropriate? No, we'll wrap the entire page in a <section cross-fade>. Faster and easier than cross-fading a bunch of elements. Check out the changes to a11y_page.html in the next CL here: https://codereview.chromium.org/986843002/diff2/100001:120001/chrome/browser/... I figure it's not worth modifying a11y_page.html for this CL, especially since there's only one page. Jeremy Klein 2015/03/13 00:49:31 Cool, that works too. Thanks. Show quoted text On 2015/03/13 00:47:01, michaelpg wrote: > On 2015/03/12 06:46:36, Jeremy Klein wrote: > > For the cross-fade, are you just thinking we'll add the cross fade on elements > > inside the pages where appropriate? > > No, we'll wrap the entire page in a <section cross-fade>. Faster and easier than > cross-fading a bunch of elements. > > Check out the changes to a11y_page.html in the next CL here: > https://codereview.chromium.org/986843002/diff2/100001:120001/chrome/browser/... > > I figure it's not worth modifying a11y_page.html for this CL, especially since > there's only one page. Cool, that works too. Thanks.
	13 <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>

	14 </core-animated-pages>

	15 </paper-shadow>

	16 </div>

	17 </template>

	18 <script src="settings_main.js"></script>

	19 </polymer-element>

OLD	NEW