chrome/browser/resources/settings/settings_drawer/settings_drawer.html - Issue 981203007: Scaffold for MD-Settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_drawer/settings_drawer.html

Issue 981203007: Scaffold for MD-Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: some fixes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/a11y_page/a11y_page.js ('K') | « chrome/browser/resources/settings/settings_drawer/settings_drawer.css ('k') | chrome/browser/resources/settings/settings_drawer/settings_drawer.js » ('j') | chrome/browser/resources/settings/settings_main/settings_main.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://md-settings/settings_menu/settings_menu.html">

	3

	4 <polymer-element name="cr-settings-drawer" layout vertical>

	5 <template>

	6 <link rel="stylesheet" href="settings_drawer.css">

	7 <!-- TODO(michaelpg): Create a new user card component. -->

	8 <div id="user-card" class="medium" layout horizontal center>

	9 <img src="{{user.iconUrl}}">

	10 <div flex>

	11 <div class="name">{{user.name}}</div>

	12 <div class="email">{{user.email}}</div>

	13 </div>

	14 </div>

	15 <cr-settings-menu flex selectedId="{{selectedId}}" pages="{{pages}}">
	Oren Blasberg 2015/03/12 18:58:17 Side note: As I am learning polymer I'm starting Side note: As I am learning polymer I'm starting to expect certain 'magic' things and am a bit surprised that new attributes like 'selectedId' aren't automatically converted from camelCase in the JS, to dashed-notation in the html :P I wonder if that's in the pipe for them. michaelpg 2015/03/13 00:47:01 Yeah! Attribute conversion to camelCase already ex Show quoted text On 2015/03/12 18:58:17, Oren Blasberg wrote: > Side note: As I am learning polymer I'm starting to expect certain 'magic' > things and am a bit surprised that new attributes like 'selectedId' aren't > automatically converted from camelCase in the JS, to dashed-notation in the html > :P I wonder if that's in the pipe for them. Yeah! Attribute conversion to camelCase already exists in 0.8. There's nothing for this.$ yet so I filed: https://github.com/Polymer/polymer/issues/1290
	16 </cr-settings-menu>

	17 </template>

	18 <script src="settings_drawer.js"></script>

	19 </polymer-element>

OLD	NEW