chrome/browser/resources/settings/settings_main/settings_main.html - Issue 981203007: Scaffold for MD-Settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 981203007: Scaffold for MD-Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback. Update core-selected-pages usage. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_drawer/settings_drawer.js ('K') | « chrome/browser/resources/settings/settings_main/settings_main.css ('k') | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | chrome/browser/resources/settings/settings_main/settings_main.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/core-animated-pages/core-ani mated-pages.html">

	3 <link rel="import" href="chrome://resources/polymer/core-transition/core-transit ion.html">

	4

	5 <polymer-element name="cr-settings-main">

	6 <template>

	7 <link rel="stylesheet" href="settings_main.css">

	8 <div id="container">

	9 <paper-shadow flex>
	Jeremy Klein 2015/03/12 02:11:18 Do we want flex or fit here? The container doesn't Do we want flex or fit here? The container doesn't seem to be display: flex; so I'm not sure how this affects anything. We might just be able to get rid of it. I assume it's here for when the help articles come in, right? Maybe we should just wait until that lands to add the flexing here and in the css. Also, when you do that, you can write "flex two" and get rid of the flex: 2 in the css. michaelpg 2015/03/12 06:29:37 Spot on. Removed for now, thanks. Show quoted text On 2015/03/12 02:11:18, Jeremy Klein wrote: > Do we want flex or fit here? The container doesn't seem to be display: flex; so > I'm not sure how this affects anything. We might just be able to get rid of it. > I assume it's here for when the help articles come in, right? Maybe we should > just wait until that lands to add the flexing here and in the css. Also, when > you do that, you can write "flex two" and get rid of the flex: 2 in the css. Spot on. Removed for now, thanks.
	10 <core-animated-pages id="pages" selected="{{selectedPageId}}"

	11 valueattr="PAGE_ID" excludeLocalNames="template"
	Jeremy Klein 2015/03/12 02:11:18 nit: not sure you need the excludedLocalNames any nit: not sure you need the excludedLocalNames any more. michaelpg 2015/03/12 06:29:37 Done. Show quoted text On 2015/03/12 02:11:18, Jeremy Klein wrote: > nit: not sure you need the excludedLocalNames any more. Done.
	12 transitions="cross-fade">

	13 <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>

	14 </core-animated-pages>

	15 </paper-shadow>

	16 </div>

	17 </template>

	18 <script src="settings_main.js"></script>

	19 </polymer-element>

OLD	NEW