chrome/browser/resources/settings/settings_main/settings_main.css - Issue 981203007: Scaffold for MD-Settings.

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.css

Issue 981203007: Scaffold for MD-Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove help Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_drawer/settings_drawer.js ('K') | « chrome/browser/resources/settings/settings_drawer/settings_drawer.js ('k') | chrome/browser/resources/settings/settings_main/settings_main.html » ('j') | chrome/browser/resources/settings/settings_main/settings_main.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright 2015 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file. */

	4

	5 :host {

	6 background-color: rgb(219, 222, 224);
	Jeremy Klein 2015/03/09 21:17:14 Same question as the other CL about where these co Same question as the other CL about where these color values came from. michaelpg 2015/03/09 22:24:11 Straight from the mocks. Show quoted text On 2015/03/09 21:17:14, Jeremy Klein wrote: > Same question as the other CL about where these color values came from. Straight from the mocks. stevenjb 2015/03/10 17:22:53 Weren't we going to look into a better way to defi Show quoted text On 2015/03/09 22:24:11, michaelpg wrote: > On 2015/03/09 21:17:14, Jeremy Klein wrote: > > Same question as the other CL about where these color values came from. > > Straight from the mocks. Weren't we going to look into a better way to define colors? Not that I have any suggestions mind you. Jeremy Klein 2015/03/10 17:27:05 Michael and I talked about this briefly off-thread Show quoted text On 2015/03/10 17:22:53, stevenjb wrote: > On 2015/03/09 22:24:11, michaelpg wrote: > > On 2015/03/09 21:17:14, Jeremy Klein wrote: > > > Same question as the other CL about where these color values came from. > > > > Straight from the mocks. > > Weren't we going to look into a better way to define colors? Not that I have any > suggestions mind you. Michael and I talked about this briefly off-thread and we think this can probably be done using core-style, but it's probably worth doing in another CL. For now, I think we should go with colors from: http://www.google.com/design/spec/style/color.html stevenjb 2015/03/10 17:28:42 sgtm Show quoted text On 2015/03/10 17:27:05, Jeremy Klein wrote: > On 2015/03/10 17:22:53, stevenjb wrote: > > On 2015/03/09 22:24:11, michaelpg wrote: > > > On 2015/03/09 21:17:14, Jeremy Klein wrote: > > > > Same question as the other CL about where these color values came from. > > > > > > Straight from the mocks. > > > > Weren't we going to look into a better way to define colors? Not that I have > any > > suggestions mind you. > > Michael and I talked about this briefly off-thread and we think this can > probably be done using core-style, but it's probably worth doing in another CL. > For now, I think we should go with colors from: > > http://www.google.com/design/spec/style/color.html sgtm michaelpg 2015/03/12 01:41:39 I spoke with Cody, who said he's still waiting to Show quoted text On 2015/03/10 17:27:05, Jeremy Klein wrote: > On 2015/03/10 17:22:53, stevenjb wrote: > > On 2015/03/09 22:24:11, michaelpg wrote: > > > On 2015/03/09 21:17:14, Jeremy Klein wrote: > > > > Same question as the other CL about where these color values came from. > > > > > > Straight from the mocks. > > > > Weren't we going to look into a better way to define colors? Not that I have > any > > suggestions mind you. > > Michael and I talked about this briefly off-thread and we think this can > probably be done using core-style, but it's probably worth doing in another CL. > For now, I think we should go with colors from: > > http://www.google.com/design/spec/style/color.html I spoke with Cody, who said he's still waiting to hear back about the colors. But he did say the deviation from the specs was intentional. Rather than do the work of finding colors from the spec that could change soon, I think we should just move forward with the understanding that colors (like the rest of the UI) haven't been signed off on. Jeremy Klein 2015/03/12 02:11:18 Ok, sounds good to me. Show quoted text On 2015/03/12 01:41:39, michaelpg wrote: > On 2015/03/10 17:27:05, Jeremy Klein wrote: > > On 2015/03/10 17:22:53, stevenjb wrote: > > > On 2015/03/09 22:24:11, michaelpg wrote: > > > > On 2015/03/09 21:17:14, Jeremy Klein wrote: > > > > > Same question as the other CL about where these color values came from. > > > > > > > > Straight from the mocks. > > > > > > Weren't we going to look into a better way to define colors? Not that I have > > any > > > suggestions mind you. > > > > Michael and I talked about this briefly off-thread and we think this can > > probably be done using core-style, but it's probably worth doing in another > CL. > > For now, I think we should go with colors from: > > > > http://www.google.com/design/spec/style/color.html > > I spoke with Cody, who said he's still waiting to hear back about the colors. > But he did say the deviation from the specs was intentional. Rather than do the > work of finding colors from the spec that could change soon, I think we should > just move forward with the understanding that colors (like the rest of the UI) > haven't been signed off on. Ok, sounds good to me.
	7 color: black;

	8 display: block;

	9 }

	10

	11 #container {

	12 box-sizing: border-box;

	13 height: 100%;

	14 overflow: auto;

	15 padding-top: 5px;

	16 }

	17

	18 core-animated-pages {

	19 background-color: white;

	20 border-radius: 2px;
	Jeremy Klein 2015/03/09 21:17:14 I'm not sure I see where there's a border-radius f I'm not sure I see where there's a border-radius for this in the mocks... michaelpg 2015/03/09 22:24:11 You're right, will remove. Show quoted text On 2015/03/09 21:17:14, Jeremy Klein wrote: > I'm not sure I see where there's a border-radius for this in the mocks... You're right, will remove.
	21 box-shadow: -2px 2px 3px 0 rgb(194, 197, 199);
	Jeremy Klein 2015/03/09 21:17:14 Shouldn't we be using a paper-shadow for this to m Shouldn't we be using a paper-shadow for this to match material shadows exactly? michaelpg 2015/03/12 01:41:39 Done. Show quoted text On 2015/03/09 21:17:14, Jeremy Klein wrote: > Shouldn't we be using a paper-shadow for this to match material shadows exactly? Done.
	22 flex: 2;

	23 margin: 0 20px 0;
	Jeremy Klein 2015/03/09 21:17:14 RTL? RTL? Dan Beam 2015/03/09 21:23:30 this is the same in LTR and RTL and could be short Show quoted text On 2015/03/09 21:17:14, Jeremy Klein wrote: > RTL? this is the same in LTR and RTL and could be shortened to: 0 20px Jeremy Klein 2015/03/09 21:25:18 Ah yeah, are you overriding some left margin, thou Show quoted text On 2015/03/09 21:23:30, Dan Beam wrote: > On 2015/03/09 21:17:14, Jeremy Klein wrote: > > RTL? > > this is the same in LTR and RTL and could be shortened to: 0 20px Ah yeah, are you overriding some left margin, though with 0? michaelpg 2015/03/12 01:41:39 I'm adding a 20px margin on either side. Show quoted text On 2015/03/09 21:25:18, Jeremy Klein wrote: > On 2015/03/09 21:23:30, Dan Beam wrote: > > On 2015/03/09 21:17:14, Jeremy Klein wrote: > > > RTL? > > > > this is the same in LTR and RTL and could be shortened to: 0 20px > > Ah yeah, are you overriding some left margin, though with 0? I'm adding a 20px margin on either side.
	24 }

	25

	26 core-animated-pages > section {

	27 padding: 10px;

	28 }

OLD	NEW