chrome/browser/resources/settings/settings_drawer/settings_drawer.html - Issue 981203007: Scaffold for MD-Settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_drawer/settings_drawer.html

Issue 981203007: Scaffold for MD-Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove help Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_drawer/settings_drawer.css ('K') | « chrome/browser/resources/settings/settings_drawer/settings_drawer.css ('k') | chrome/browser/resources/settings/settings_drawer/settings_drawer.js » ('j') | chrome/browser/resources/settings/settings_drawer/settings_drawer.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://md-settings/settings_menu/settings_menu.html">

	3

	4 <polymer-element name="cr-settings-drawer" layout vertical>

	5 <template>

	6 <link rel="stylesheet" href="settings_drawer.css">

	7 <div id="user-card" class="medium" horizontal layout center>
	stevenjb 2015/03/10 17:22:53 nit: 'layout vertical' above, 'horizontal layout' nit: 'layout vertical' above, 'horizontal layout' here. (I know it doesn't matter, just a little confusing to read). Also, does it make sense to make the user card its own component? I don't know if we'll ever use it elsewhere, but it does feel rather componenty. michaelpg 2015/03/12 01:41:39 Done. Show quoted text On 2015/03/10 17:22:53, stevenjb wrote: > nit: 'layout vertical' above, 'horizontal layout' here. (I know it doesn't > matter, just a little confusing to read). Done. Show quoted text > > Also, does it make sense to make the user card its own component? I don't know > if we'll ever use it elsewhere, but it does feel rather componenty. Yes. I think it would add more noise to this CL though, so I've added a TODO.
	8 <img src="{{user.avatar}}">

	9 <div flex>

	10 <div class="name">{{user.name}}</div>

	11 <div class="email">{{user.email}}</div>

	12 </div>

	13 </div>

	14 <cr-settings-menu selectedIndex="{{selectedIndex}}" pages="{{pages}}" flex>

	15 </cr-settings-menu>

	16 </template>

	17 <script src="settings_drawer.js"></script>

	18 </polymer-element>

OLD	NEW