Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 981193003: Implement the "sanity checks" described in b/9509040: Incoming packets (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Change_null_value_87819844
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement the "sanity checks" described in b/9509040: Incoming packets whose connection ID is not associated with a session and is not recorded as being in time-wait state are tested for reasonableness before a session is created for them. This won't protect much against deliberate DoS but will screen out a reasonable fraction of truly junk packets. Add sanity tests so we do not create connections for initial packets with truncated connection IDs. Merge internal change: 87831756 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -58 lines) Patch
M net/quic/quic_dispatcher.h View 1 chunk +11 lines, -0 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 3 chunks +54 lines, -26 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +11 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +15 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +11 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +54 lines, -26 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 4 chunks +15 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +15 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-07 01:37:57 UTC) #1
Ryan Hamilton
5 years, 9 months ago (2015-03-07 03:17:57 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698