Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 981183003: Revert "ScopedCrashKey doesn't appear to be configured to work on Windows. Manually set the crash k… (Closed)

Created:
5 years, 9 months ago by erikwright (departed)
Modified:
5 years, 9 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_crash_logging
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "ScopedCrashKey doesn't appear to be configured to work on Windows. Manually set the crash key." This reverts commit af3e767a66b82c6f8510db2fb8eeeb0d2f89409c. The reverted code is a workaround. The root cause is addressed by http://crrev.com/985763004/ . BUG=460512 Committed: https://crrev.com/08078f62ef73216b1c15508c9ad25f86933ee2f7 Cr-Commit-Position: refs/heads/master@{#319631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M chrome/app/kasko_client.cc View 2 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikwright (departed)
grt: PTAL upon your return.
5 years, 9 months ago (2015-03-06 21:24:17 UTC) #2
grt (UTC plus 2)
lgtm
5 years, 9 months ago (2015-03-09 14:05:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981183003/1
5 years, 9 months ago (2015-03-09 14:35:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 15:22:01 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 15:22:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08078f62ef73216b1c15508c9ad25f86933ee2f7
Cr-Commit-Position: refs/heads/master@{#319631}

Powered by Google App Engine
This is Rietveld 408576698