Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

Issue 981143003: dart2js: split out types from metadata. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
index fc014bc01191a02ff1307f09e382e110df90efd8..3156eb4418b33cd8bbb95d06062f73708fcd2b06 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
@@ -50,8 +50,8 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
emitter.generateEmbeddedGlobalAccess(embeddedNames.MANGLED_NAMES);
jsAst.Expression librariesAccess =
emitter.generateEmbeddedGlobalAccess(embeddedNames.LIBRARIES);
- jsAst.Expression metadataAccess =
- emitter.generateEmbeddedGlobalAccess(embeddedNames.METADATA);
+ jsAst.Expression typesAccess =
+ emitter.generateEmbeddedGlobalAccess(embeddedNames.TYPES);
jsAst.Statement processClassData = js.statement('''{
function processClassData(cls, descriptor, processedClasses) {
@@ -115,7 +115,7 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
if (functionSignature)
newDesc.${namer.operatorSignature} = function(s) {
return function() {
- return #metadata[s];
+ return #types[s];
};
}(functionSignature);
}
@@ -130,7 +130,7 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
}
}''', {'embeddedStatics': staticsAccess,
'hasRetainedMetadata': backend.hasRetainedMetadata,
- 'metadata': metadataAccess,
+ 'types': typesAccess,
'notInCspMode': !compiler.useContentSecurityPolicy});
// TODO(zarah): Remove empty else branches in output when if(#hole) is false.
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | sdk/lib/_internal/compiler/js_lib/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698