Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: remoting/webapp/base/js/application.js

Issue 981083002: [Chromoting] Move ownership of ClientPlugin into SessionConnector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Create ClientSession after plugin is created Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/application.js
diff --git a/remoting/webapp/base/js/application.js b/remoting/webapp/base/js/application.js
index d270cc9f989c953b75d47f41ecd35ea5e7f6494f..1aaf036cde5164d907dac14d79f8a2a9a74a6c02 100644
--- a/remoting/webapp/base/js/application.js
+++ b/remoting/webapp/base/js/application.js
@@ -13,19 +13,6 @@
var remoting = remoting || {};
/**
- * @type {remoting.ClientSession} The client session object, set once the
- * connector has invoked its onOk callback.
- * TODO(garykac): Make clientSession a member var of Application.
- */
-remoting.clientSession = null;
-
-/**
- * @type {remoting.DesktopConnectedView} The client session view object, set
- * once the connector has invoked its onOk callback.
- */
-remoting.desktopConnectedView = null;
-
-/**
* @param {Array<string>} app_capabilities Array of application capabilities.
* @constructor
*/
@@ -124,7 +111,6 @@ remoting.Application.prototype.disconnect = function() {
* @return {void} Nothing.
*/
remoting.Application.prototype.onConnected = function(clientSession) {
- remoting.clientSession = clientSession;
this.sessionConnectedHooks_ = new base.Disposables(
new base.EventHook(
clientSession, 'stateChanged', this.onClientStateChange_.bind(this)),
« no previous file with comments | « no previous file | remoting/webapp/browser_test/mock_session_connector.js » ('j') | remoting/webapp/crd/js/client_session.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698