remoting/webapp/base/js/application.js - Issue 981083002: [Chromoting] Move ownership of ClientPlugin into SessionConnector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/base/js/application.js

Issue 981083002: [Chromoting] Move ownership of ClientPlugin into SessionConnector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove createPluginAndConnect Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/base/js/application.js

diff --git a/remoting/webapp/base/js/application.js b/remoting/webapp/base/js/application.js

index d270cc9f989c953b75d47f41ecd35ea5e7f6494f..efe8859e7957d833f01d604cc2a13f6e972f55b8 100644

--- a/remoting/webapp/base/js/application.js

+++ b/remoting/webapp/base/js/application.js

@@ -124,7 +124,6 @@ remoting.Application.prototype.disconnect = function() {

* @return {void} Nothing.

remoting.Application.prototype.onConnected = function(clientSession) {

- remoting.clientSession = clientSession;

garykac 2015/03/06 00:45:04 This global is managed in SessionConnector.

this.sessionConnectedHooks_ = new base.Disposables(

new base.EventHook(

clientSession, 'stateChanged', this.onClientStateChange_.bind(this)),

« no previous file with comments | « no previous file | remoting/webapp/browser_test/mock_session_connector.js » ('j') | remoting/webapp/browser_test/mock_session_connector.js » ('J')