[Chromoting] Move ownership of ClientPlugin into SessionConnector.

remoting/webapp/base/js/application.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Interface abstracting the Application functionality.
  */
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * @type {remoting.ClientSession} The client session object, set once the
  *     connector has invoked its onOk callback.
  * TODO(garykac): Make clientSession a member var of Application.
  */
 remoting.clientSession = null;

[kelvinp, 2015/03/06 02:58:37]

Please also moves it to sessionConnector, if you are goign to initialize the
session there.

[garykac, 2015/03/06 23:38:33]

Done.

 
 /**
  * @type {remoting.DesktopConnectedView} The client session view object, set
  *     once the connector has invoked its onOk callback.
  */
 remoting.desktopConnectedView = null;
 
 /**
  * @param {Array<string>} app_capabilities Array of application capabilities.
  * @constructor
@@ skipping 86 matching lines @@
   }
 };
 
 /**
  * Called when a new session has been connected.
  *
  * @param {remoting.ClientSession} clientSession
  * @return {void} Nothing.
  */
 remoting.Application.prototype.onConnected = function(clientSession) {
-  remoting.clientSession = clientSession;
   this.sessionConnectedHooks_ = new base.Disposables(
     new base.EventHook(
       clientSession, 'stateChanged', this.onClientStateChange_.bind(this)),
     new base.RepeatingTimer(this.updateStatistics_.bind(this), 1000)
   );
   remoting.clipboard.startSession();
 
   this.delegate_.handleConnected(clientSession);
 };
 
@@ skipping 104 matching lines @@
     default:
       console.error('Unexpected client plugin state: ' + state.current);
       // This should only happen if the web-app and client plugin get out of
       // sync, so MISSING_PLUGIN is a suitable error.
       this.onError(remoting.Error.MISSING_PLUGIN);
       break;
   }
 
   base.dispose(this.sessionConnectedHooks_);
   this.sessionConnectedHooks_= null;
   remoting.clientSession.dispose();

[kelvinp, 2015/03/06 02:58:37]

Previously, this will actually remove the plugin. With this change, it is a
no-op.  We should call removePlugin on the sessionConnector instead.

   remoting.clientSession = null;
 };
 
 /** @private */
 remoting.Application.prototype.updateStatistics_ = function() {
   var perfstats = remoting.clientSession.getPerfStats();
   remoting.stats.update(perfstats);
   remoting.clientSession.logStatistics(perfstats);
 };
 
@@ skipping 70 matching lines @@
  * Called when an error needs to be displayed to the user.
  *
  * @param {remoting.Error} errorTag The error to be localized and displayed.
  * @return {void} Nothing.
  */
 remoting.Application.Delegate.prototype.handleError = function(errorTag) {};
 
 
 /** @type {remoting.Application} */
 remoting.app = null;