Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: remoting/webapp/base/js/application.js

Issue 981083002: [Chromoting] Move ownership of ClientPlugin into SessionConnector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove createPluginAndConnect Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * Interface abstracting the Application functionality. 7 * Interface abstracting the Application functionality.
8 */ 8 */
9 9
10 'use strict'; 10 'use strict';
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 } 117 }
118 }; 118 };
119 119
120 /** 120 /**
121 * Called when a new session has been connected. 121 * Called when a new session has been connected.
122 * 122 *
123 * @param {remoting.ClientSession} clientSession 123 * @param {remoting.ClientSession} clientSession
124 * @return {void} Nothing. 124 * @return {void} Nothing.
125 */ 125 */
126 remoting.Application.prototype.onConnected = function(clientSession) { 126 remoting.Application.prototype.onConnected = function(clientSession) {
127 remoting.clientSession = clientSession;
garykac 2015/03/06 00:45:04 This global is managed in SessionConnector.
128 this.sessionConnectedHooks_ = new base.Disposables( 127 this.sessionConnectedHooks_ = new base.Disposables(
129 new base.EventHook( 128 new base.EventHook(
130 clientSession, 'stateChanged', this.onClientStateChange_.bind(this)), 129 clientSession, 'stateChanged', this.onClientStateChange_.bind(this)),
131 new base.RepeatingTimer(this.updateStatistics_.bind(this), 1000) 130 new base.RepeatingTimer(this.updateStatistics_.bind(this), 1000)
132 ); 131 );
133 remoting.clipboard.startSession(); 132 remoting.clipboard.startSession();
134 133
135 this.delegate_.handleConnected(clientSession); 134 this.delegate_.handleConnected(clientSession);
136 }; 135 };
137 136
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 * Called when an error needs to be displayed to the user. 332 * Called when an error needs to be displayed to the user.
334 * 333 *
335 * @param {remoting.Error} errorTag The error to be localized and displayed. 334 * @param {remoting.Error} errorTag The error to be localized and displayed.
336 * @return {void} Nothing. 335 * @return {void} Nothing.
337 */ 336 */
338 remoting.Application.Delegate.prototype.handleError = function(errorTag) {}; 337 remoting.Application.Delegate.prototype.handleError = function(errorTag) {};
339 338
340 339
341 /** @type {remoting.Application} */ 340 /** @type {remoting.Application} */
342 remoting.app = null; 341 remoting.app = null;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698