components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java - Issue 981013002: [Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK fa

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

Issue 981013002: [Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK fa (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add ChromiumUrlRequestContext test too Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

diff --git a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

index bb84b911c92fb56d4713de938cddfb7e716e2e38..d54c36330d717d08e8cf994e24dde5fbc123e7d3 100644

--- a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

+++ b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

@@ -102,8 +102,7 @@ public class CronetSampleActivity extends Activity {

}

- mRequestFactory = HttpUrlRequestFactory.createFactory(

- getApplicationContext(), config);

+ mRequestFactory = HttpUrlRequestFactory.createFactory(this, config);

String appUrl = getUrlFromIntent(getIntent());

if (appUrl == null) {

@@ -192,8 +191,7 @@ public class CronetSampleActivity extends Activity {

public void startNetLog() {

mRequestFactory.startNetLogToFile(

- Environment.getExternalStorageDirectory().getPath() +

- "/cronet_sample_netlog.json");

+ Environment.getExternalStorageDirectory().getPath() + "/cronet_sample_netlog.json");

}

public void stopNetLog() {