components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java - Issue 981013002: [Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK fa

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 981013002: [Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK fa (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add ChromiumUrlRequestContext test too Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_library_loader.cc ('k') | components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

index 07bcd9bcd7dfa642aaf9420a2c30f7614f69a1e1..474f944c7565801619c51f634207b0a2b98ddd3c 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

@@ -34,7 +34,7 @@ public class ChromiumUrlRequestContext {

protected ChromiumUrlRequestContext(final Context context, String userAgent,

String config) {

mChromiumUrlRequestContextAdapter = nativeCreateRequestContextAdapter(

- context, userAgent, getLoggingLevel(), config);

+ context.getApplicationContext(), userAgent, getLoggingLevel(), config);

if (mChromiumUrlRequestContextAdapter == 0) {

throw new NullPointerException("Context Adapter creation failed");

}

@@ -134,8 +134,8 @@ public class ChromiumUrlRequestContext {

// Returns an instance ChromiumUrlRequestContextAdapter to be stored in

// mChromiumUrlRequestContextAdapter.

- private native long nativeCreateRequestContextAdapter(Context context,

- String userAgent, int loggingLevel, String config);

+ private native long nativeCreateRequestContextAdapter(

+ Context appContext, String userAgent, int loggingLevel, String config);

private native void nativeReleaseRequestContextAdapter(

long chromiumUrlRequestContextAdapter);