components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java - Issue 981013002: [Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK fa

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

Issue 981013002: [Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK fa (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/chromium_url_request_context.cc ('K') | « components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java ('k') | components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java » ('j') | components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

index eb9ef75d1a7e7ad1fba588d573fe814d0d3827a3..3ba1e5843e2c341e7c91d99808a0c892714242d8 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

@@ -25,8 +25,7 @@ public class ChromiumUrlRequestFactory extends HttpUrlRequestFactory {

if (isEnabled()) {

CronetLibraryLoader.ensureInitialized(context, config);

mRequestContext = new ChromiumUrlRequestContext(

- context.getApplicationContext(), UserAgent.from(context),

- config.toString());

+ context, UserAgent.from(context), config.toString());

mef 2015/03/06 16:55:55 Just to make sure I understand correctly: it is ok

pauljensen 2015/03/06 17:16:52 Calling getApplicationContext() on an application

}