[Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK fa

components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
+import android.content.ContextWrapper;
 import android.os.ConditionVariable;
 import android.os.Handler;
 import android.os.Looper;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.PathUtils;
 import org.chromium.base.test.util.Feature;
 import org.chromium.net.TestUrlRequestListener.FailureType;
 import org.chromium.net.TestUrlRequestListener.ResponseStep;
 
@@ skipping 494 matching lines @@
         assertTrue(NativeTestServer.startNativeTestServer(
                 getInstrumentation().getTargetContext()));
         String url = NativeTestServer.getFileURL("/cacheable.txt");
         checkRequestCaching(url, false);
         checkRequestCaching(url, true);
         NativeTestServer.shutdownNativeTestServer();
         checkRequestCaching(url, true);
         // Shutdown original context and create another that uses the same cache.
         mActivity.mUrlRequestContext.shutdown();
         mActivity.mUrlRequestContext = mActivity.mUrlRequestContext.createContext(
-                getInstrumentation().getTargetContext().getApplicationContext(),
-                config);
+                getInstrumentation().getTargetContext(), config);
         checkRequestCaching(url, true);
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testInitContextAndStartRequest() {
         CronetTestActivity activity = skipFactoryInitInOnCreate();
 
         // Immediately make a request after initializing the context.
         UrlRequestContext requestContext = activity.initRequestContext();
@@ skipping 54 matching lines @@
         RequestThread thread1 = new RequestThread(activity, TEST_URL, runBlocker);
         RequestThread thread2 = new RequestThread(activity, URL_404, runBlocker);
 
         thread1.start();
         thread1.join();
         thread2.start();
         thread2.join();
         assertEquals(200, thread1.mListener.mResponseInfo.getHttpStatusCode());
         assertEquals(404, thread2.mListener.mResponseInfo.getHttpStatusCode());
     }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    public void testInitDifferentContexts() throws Exception {

[xunjieli, 2015/03/06 14:50:31]

Btw, should we test creating multiple ChromiumUrlRequestContext too?

[pauljensen, 2015/03/06 17:01:53]

Done.

+        // Test that concurrently instantiating Cronet context's upon various
+        // different versions of the same Android Context does not cause crashes
+        // like crbug.com/453845
+        mActivity = launchCronetTestApp();
+        CronetUrlRequestContext firstContext =
+                new CronetUrlRequestContext(mActivity, new UrlRequestContextConfig());
+        CronetUrlRequestContext secondContext = new CronetUrlRequestContext(
+                mActivity.getApplicationContext(), new UrlRequestContextConfig());

[mmenke, 2015/03/06 16:52:23]

Shouldn't you just be passing in the mActivity here?

[pauljensen, 2015/03/06 16:57:28]

That's what I do on the previous line.
I'm trying three easy situations concurrently:
1. mActivity
2. mActivity's application context (kind of the parent of mActivity)
3. a wrapper on mActivity (kind of a child of mActivity)

+        CronetUrlRequestContext thirdContext = new CronetUrlRequestContext(
+                new ContextWrapper(mActivity), new UrlRequestContextConfig());
+        firstContext.shutdown();
+        secondContext.shutdown();
+        thirdContext.shutdown();
+    }
 }