Simple GAE/goon Context wrapper

Simple GAE/goon Context wrapper

This is useful for restricting an API to implement 'datastore without queries'
or 'key-only context', etc.

R=vadimsh@chromium.org
BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/bce95975f64973f7e8d5cf8735ed4eda35ca23a5

[Vadim Sh., 2015-03-06 02:54:27]

lgtm, though not really g, but it's kind of a matter of personal taste, so g
anyway

https://codereview.chromium.org/981003003/diff/20001/go/src/infra/gae/libs/co...
File go/src/infra/gae/libs/context/context.go (right):

https://codereview.chromium.org/981003003/diff/20001/go/src/infra/gae/libs/co...
go/src/infra/gae/libs/context/context.go:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
I assume all the permutations are actually used down the road somewhere?

Perhaps you can define only "atomic" interfaces here and define all needed
combinations closer to where they are used?

https://codereview.chromium.org/981003003/diff/20001/go/src/infra/gae/libs/co...
go/src/infra/gae/libs/context/context.go:106: type DangerousTransactionerContext
interface {
nit: maybe "FullContext" or "CompleteContext" or "MaxContext"?..
DangerousTransactionerContext is too long to type. And what if you suddenly need
some new trait similar to "Transactioner" DangerousTransactionerFunnierContext?

[iannucci, 2015-03-07 02:30:55]

On 2015/03/06 at 02:54:27, vadimsh wrote:
> lgtm, though not really g, but it's kind of a matter of personal taste, so g
anyway
> 
>
https://codereview.chromium.org/981003003/diff/20001/go/src/infra/gae/libs/co...
> File go/src/infra/gae/libs/context/context.go (right):
> 
>
https://codereview.chromium.org/981003003/diff/20001/go/src/infra/gae/libs/co...
> go/src/infra/gae/libs/context/context.go:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
> I assume all the permutations are actually used down the road somewhere?
> 
> Perhaps you can define only "atomic" interfaces here and define all needed
combinations closer to where they are used?
> 
>
https://codereview.chromium.org/981003003/diff/20001/go/src/infra/gae/libs/co...
> go/src/infra/gae/libs/context/context.go:106: type
DangerousTransactionerContext interface {
> nit: maybe "FullContext" or "CompleteContext" or "MaxContext"?..
DangerousTransactionerContext is too long to type. And what if you suddenly need
some new trait similar to "Transactioner" DangerousTransactionerFunnierContext?

Yeah... it's a loose but (probably) practical way... don't want to get all
java-ey up in here :P. Not like go gives me a lot of choice....

[iannucci, 2015-03-07 02:31:01]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2015-03-07 02:32:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/981003003/20001

[commit-bot: I haz the power, 2015-03-07 03:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 03:00:54]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[iannucci, 2015-03-12 00:56:08]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-03-12 00:56:09]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/981003003/#ps40001 (title:
"skip testing for context")

[commit-bot: I haz the power, 2015-03-12 00:56:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/981003003/40001

[commit-bot: I haz the power, 2015-03-12 00:59:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/bce95975f64973f7e8d5cf8735ed4...