Issue 980953002: stocks and stocks-fn should share the stocks data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 980953002: stocks and stocks-fn should share the stocks data (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

stocks and stocks-fn should share the stocks data Previously, the two versions of this sample app had separate copies of the stock data. This CL moves the common data to the common data directory so that they can share. Also, I've switched the data files to be |dart| files rather than |sky| files to make them easier to use from fn examples. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ea492baa48c9b721e7bf77c84da225248cf39542

Patch Set 1 #

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -11050 lines)			Patch
A +	sky/examples/data/cities.dart	View	2 chunks	+1 line, -4 lines	0 comments	Download
D	sky/examples/data/cities.sky	View	1 chunk	+0 lines, -5008 lines	0 comments	Download
A +	sky/examples/data/stocks.dart	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	sky/examples/scrolling/scrolling.sky	View	2 chunks	+1 line, -1 line	0 comments	Download
D	sky/examples/stocks-fn/companylist.dart	View	1 chunk	+0 lines, -3015 lines	0 comments	Download
M	sky/examples/stocks-fn/stocksapp.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	sky/examples/stocks/companylist.sky	View	1 chunk	+0 lines, -3017 lines	0 comments	Download
M	sky/examples/stocks/stocks.sky	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 9 months ago (2015-03-05 17:56:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ea492baa48c9b721e7bf77c84da225248cf39542 (presubmit successful).

Expand Messages | Collapse Messages