pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart - Issue 980853002: dart2dart: Bugfix in copy propagator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart

Issue 980853002: dart2dart: Bugfix in copy propagator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Renamed Assign.definition -> value and break up long condition Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart

diff --git a/pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart b/pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart

index 0913a117172b7e3ea4c3bf6f168d5cf115606418..2670be74d251fcc79306b466bdace5632e591ad6 100644

--- a/pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart

+++ b/pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart

@@ -43,13 +43,13 @@ class LoopRewriter extends RecursiveVisitor with PassMixin {

Statement visitAssign(Assign node) {

// Clean up redundant assignments left behind in the previous phase.

- Expression def = node.definition;

- if (def is VariableUse && node.variable == def.variable) {

+ Expression value = node.value;

+ if (value is VariableUse && node.variable == value.variable) {

--node.variable.readCount;

--node.variable.writeCount;

return visitStatement(node.next);

}

- visitExpression(node.definition);

+ visitExpression(node.value);

node.next = visitStatement(node.next);

return node;

}