Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 98073012: Add unit test for lock and unlock virtual keyboard feature (Closed)

Created:
7 years ago by bshe
Modified:
6 years, 11 months ago
Reviewers:
SteveT, rsadam
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Add unit test for lock and unlock virtual keyboard feature BUG=326170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244225

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : rebase #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -13 lines) Patch
M chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/chromeos/virtual_keyboard/hide_keyboard_key_test.js View 1 2 3 4 5 6 7 8 1 chunk +127 lines, -0 lines 0 comments Download
M chrome/test/data/chromeos/virtual_keyboard/typing_test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js View 1 2 3 4 5 6 7 8 3 chunks +21 lines, -4 lines 0 comments Download
M ui/keyboard/resources/elements/kb-key.html View 1 2 3 4 5 1 chunk +4 lines, -5 lines 0 comments Download
M ui/keyboard/resources/elements/kb-key-base.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/elements/kb-keyset.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/elements/kb-options-menu.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ui/keyboard/resources/elements/kb-shift-key.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
bshe
Hey Raheem and Steve Can you guys take a look at this? It adds a ...
7 years ago (2013-12-17 01:19:46 UTC) #1
SteveT
LGTM - However, please let Raheem take a look before committing since he knows the ...
7 years ago (2013-12-17 15:43:56 UTC) #2
rsadam
lgtm
7 years ago (2013-12-17 16:10:35 UTC) #3
bshe
thanks guys https://codereview.chromium.org/98073012/diff/80001/chrome/test/data/chromeos/virtual_keyboard/hide_keyboard_key_test.js File chrome/test/data/chromeos/virtual_keyboard/hide_keyboard_key_test.js (right): https://codereview.chromium.org/98073012/diff/80001/chrome/test/data/chromeos/virtual_keyboard/hide_keyboard_key_test.js#newcode99 chrome/test/data/chromeos/virtual_keyboard/hide_keyboard_key_test.js:99: function testLockUnLockKeyboard(testDoneCallback) { On 2013/12/17 15:43:56, SteveT ...
7 years ago (2013-12-17 16:15:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/98073012/100001
7 years ago (2013-12-17 16:16:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=203913
7 years ago (2013-12-17 16:31:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/98073012/100001
7 years ago (2013-12-17 16:55:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/98073012/100001
7 years ago (2013-12-17 18:26:52 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=185852
7 years ago (2013-12-17 23:11:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/98073012/120001
7 years ago (2013-12-18 20:46:03 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=237930
7 years ago (2013-12-18 21:58:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/98073012/140001
6 years, 11 months ago (2014-01-09 15:03:12 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=189852
6 years, 11 months ago (2014-01-09 18:47:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/98073012/390001
6 years, 11 months ago (2014-01-10 17:17:34 UTC) #14
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 20:06:01 UTC) #15
Message was sent while issue was closed. 
Change committed as 244225

Powered by Google App Engine
This is Rietveld 408576698