Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 980703006: Sync HTML element interfaces E-F with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync HTML element interfaces E-F with the spec Changing the HTMLFieldSetElement and HTMLFormElement.elements type from HTMLCollection to HTMLFormControlsCollection does not change behavior, since they already return a HTMLFormControlsCollection in C++ and that object is wrapped correctly. Only some includes change in the generated code. Other than that, there are no changes to the generated code other than the order. HTMLFormElement.action is reflected as a URL by us and other tested browsers, so a spec bug was filed to make the spec agree: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28169 BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -30 lines) Patch
M Source/core/html/HTMLEmbedElement.idl View 1 chunk +15 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.idl View 1 chunk +11 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFontElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/html/HTMLFrameElement.idl View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.idl View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-08 15:46:43 UTC) #2
Jens Widell
LGTM
5 years, 9 months ago (2015-03-08 15:52:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980703006/1
5 years, 9 months ago (2015-03-09 02:57:34 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 03:00:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191507

Powered by Google App Engine
This is Rietveld 408576698