Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 980613002: convert compile functions to use maybe (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

convert compile functions to use maybe BUG=v8:3929 LOG=y Committed: https://crrev.com/95c1f5ddc87e60906e47db633898aec685a50252 Cr-Commit-Position: refs/heads/master@{#27013}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : try fix clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -138 lines) Patch
M include/v8.h View 1 2 3 4 7 chunks +30 lines, -7 lines 0 comments Download
M src/api.cc View 1 2 3 4 13 chunks +165 lines, -131 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-05 10:41:49 UTC) #3
Sven Panne
lgtm lgtm
5 years, 9 months ago (2015-03-05 10:41:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980613002/60001
5 years, 9 months ago (2015-03-05 10:49:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/2089)
5 years, 9 months ago (2015-03-05 11:30:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980613002/80001
5 years, 9 months ago (2015-03-05 11:38:41 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-05 12:26:13 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 12:26:31 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/95c1f5ddc87e60906e47db633898aec685a50252
Cr-Commit-Position: refs/heads/master@{#27013}

Powered by Google App Engine
This is Rietveld 408576698