Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 980583003: Fix FakeSigninManager::SignOut (Closed)

Created:
5 years, 9 months ago by bzanotti
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix FakeSigninManager::SignOut FakeSigninManager::SignOut was never updated to clear the account id on SignOut. This result in calls to FakeSigninManager::IsAuthenticated returning true after even after a SignOut. BUG= Committed: https://crrev.com/090c49d7c2001d5279218ecdc6c046cb78cf7c51 Cr-Commit-Position: refs/heads/master@{#319077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/signin/fake_signin_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bzanotti
Please take a look.
5 years, 9 months ago (2015-03-04 14:36:16 UTC) #2
Andrew T Wilson (Slow)
lgtm
5 years, 9 months ago (2015-03-04 17:03:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980583003/1
5 years, 9 months ago (2015-03-04 17:12:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 17:15:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 17:16:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/090c49d7c2001d5279218ecdc6c046cb78cf7c51
Cr-Commit-Position: refs/heads/master@{#319077}

Powered by Google App Engine
This is Rietveld 408576698