Serialize form_data in Gnome keyring password store service.

components/autofill/core/common/form_data.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_
 #define COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_
 
 #include <vector>
 
 #include "base/strings/string16.h"
@@ skipping 28 matching lines @@
   // A vector of all the input fields in the form.
   std::vector<FormFieldData> fields;
 };
 
 // For testing.
 std::ostream& operator<<(std::ostream& os, const FormData& form);
 
 // Serialize FormData. Used by the PasswordManager to persist FormData
 // pertaining to password forms. Serialized data is appended to |pickle|
 void SerializeFormData(const FormData& form_data, Pickle* pickle);
+// Serialize FormData. Used by the PasswordManager to persist FormData
+// pertaining to password forms.
+void SerializeFormData(const FormData& form_data, std::string* output);

[Garrett Casto, 2015/03/04 18:05:31]

Function overloading in this way is generally discouraged
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Over...).
I would change the name to something like SerializeFormDataToString() and
DeserializeFormDataFromString().

I would also mention in the comments why this function is useful, in particular
that it's base64 encoded to remove embedded NULLs. Without any context I would
just assume that this coerces the Pickle into a string.

Nit: I would also add some whitespace in between these functions. Feels a little
cramped now.

[dvadym, 2015/03/05 10:38:19]

Done, I've even added mention about base64 in functions names, this seems to be
more informative.

 // Deserialize FormData. This assumes that |iter| is currently pointing to
 // the part of a pickle created by SerializeFormData. Returns true on success.
 bool DeserializeFormData(PickleIterator* iter, FormData* form_data);
+// Deserialize FormData. Returns true on success.
+bool DeserializeFormData(const char* input, FormData* form_data);
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_