src/arm/full-codegen-arm.cc - Issue 980563002: ARM: Load undefined receiver sentinel without constant pool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 980563002: ARM: Load undefined receiver sentinel without constant pool (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index 15958ccf54561149055489f32188e1530473fb81..6142f3a846cdf0b25350742e03031af659750491 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -2913,7 +2913,8 @@ void FullCodeGenerator::EmitCallWithLoadIC(Call* expr) {

}

// Push undefined as receiver. This is patched in the method prologue if it

// is a sloppy mode method.

- __ Push(isolate()->factory()->undefined_value());

+ __ LoadRoot(ip, Heap::kUndefinedValueRootIndex);

+ __ push(ip);

} else {

// Load the function from the receiver.

DCHECK(callee->IsProperty());

« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »