src/arm/builtins-arm.cc - Issue 980563002: ARM: Load undefined receiver sentinel without constant pool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/builtins-arm.cc

Issue 980563002: ARM: Load undefined receiver sentinel without constant pool (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/builtins-arm.cc

diff --git a/src/arm/builtins-arm.cc b/src/arm/builtins-arm.cc

index ba92ff8e34f326c483d710f4d6f16482e343e746..88f1a7526ee624e0b4bccc2baae97689c9c08c15 100644

--- a/src/arm/builtins-arm.cc

+++ b/src/arm/builtins-arm.cc

@@ -928,7 +928,9 @@ static void CallCompileOptimized(MacroAssembler* masm, bool concurrent) {

// Push function as parameter to the runtime call.

__ Push(r1);

// Whether to compile in a background thread.

- __ Push(masm->isolate()->factory()->ToBoolean(concurrent));

+ __ LoadRoot(

+ ip, concurrent ? Heap::kTrueValueRootIndex : Heap::kFalseValueRootIndex);

+ __ push(ip);

__ CallRuntime(Runtime::kCompileOptimized, 2);

// Restore receiver.

« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »