Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 980563002: ARM: Load undefined receiver sentinel without constant pool (Closed)

Created:
5 years, 9 months ago by Erik Corry Chromium.org
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM: Load undefined receiver sentinel without constant pool Each call to emit_32 uses 5 constant pool slots: * the "emit_32" string * undefined (the receiver) * the argument (heap number) * the load IC * the call IC This change cuts that down 20% to 4, by loading the undefined from the heap roots. R=verwaest@chromium.org BUG= Committed: https://crrev.com/a820568b1ffbf76c3f80b9e00fc0b988b073dfaf Cr-Commit-Position: refs/heads/master@{#26979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Erik Corry Chromium.org
PTAL
5 years, 9 months ago (2015-03-04 09:40:18 UTC) #1
Toon Verwaest
Lgtm. The heap number should also already be converted to a SMI in most cases, ...
5 years, 9 months ago (2015-03-04 10:01:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980563002/1
5 years, 9 months ago (2015-03-04 10:07:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 11:02:26 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 11:02:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a820568b1ffbf76c3f80b9e00fc0b988b073dfaf
Cr-Commit-Position: refs/heads/master@{#26979}

Powered by Google App Engine
This is Rietveld 408576698