Chromium Code Reviews

Issue 980543002: Adding statusCode for webRequest onHeadersReceived and onAuthRequired callbacks (Closed)

Created:
5 years, 9 months ago by shiva.jm
Modified:
5 years, 9 months ago
Reviewers:
carloschilazo, mpcomplete, asargent_no_longer_on_chrome, battre, Savago, not at google - send to devlin
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding statusCode for webRequest onHeadersReceived and onAuthRequired callbacks BUG=447180 Committed: https://crrev.com/241fd87428d5fe9a4dc02eb7c2be59809ca05a64 Cr-Commit-Position: refs/heads/master@{#319226}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+41 lines, -11 lines)
M chrome/test/data/extensions/api_test/webrequest/test_auth_required.js View 7 chunks +14 lines, -7 lines 0 comments
M chrome/test/data/extensions/api_test/webrequest/test_blocking.js View 10 chunks +10 lines, -0 lines 0 comments
M chrome/test/data/extensions/api_test/webrequest/test_complex.js View 3 chunks +3 lines, -0 lines 0 comments
M chrome/test/data/extensions/api_test/webrequest/test_declarative1.js View 2 chunks +3 lines, -1 line 0 comments
M chrome/test/data/extensions/api_test/webrequest/test_simple.js View 2 chunks +3 lines, -1 line 0 comments
M extensions/browser/api/web_request/web_request_api.cc View 2 chunks +4 lines, -0 lines 0 comments
M extensions/common/api/web_request.json View 2 chunks +4 lines, -2 lines 0 comments

Messages

Total messages: 15 (5 generated)
shiva.jm
Please have a look.
5 years, 9 months ago (2015-03-04 07:00:18 UTC) #2
battre
lgtm
5 years, 9 months ago (2015-03-04 08:24:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980543002/1
5 years, 9 months ago (2015-03-04 08:54:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/47147)
5 years, 9 months ago (2015-03-04 09:13:01 UTC) #7
shiva.jm
Please have a look, update the patch to fix Presubmit Warnings, also Added myself to ...
5 years, 9 months ago (2015-03-04 11:22:11 UTC) #9
battre
lgtm
5 years, 9 months ago (2015-03-04 11:37:18 UTC) #10
not at google - send to devlin
lgtm
5 years, 9 months ago (2015-03-04 17:34:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980543002/20001
5 years, 9 months ago (2015-03-05 03:13:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 06:19:13 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 06:20:11 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/241fd87428d5fe9a4dc02eb7c2be59809ca05a64
Cr-Commit-Position: refs/heads/master@{#319226}

Powered by Google App Engine