Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 980523002: Roll Clang 223108:231191 (Closed)

Created:
5 years, 9 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, dmikurube+clang_chromium.org, eugenis+clang_chromium.org, jam, rickyz+watch_chromium.org, glider+clang_chromium.org, darin-cc_chromium.org, ukai+watch_chromium.org, piman+watch_chromium.org, jln+watch_chromium.org
Base URL:
precise:/work/chromium/src@clang_roll_231191
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Clang 223108:231191 Also introduce a build number in the package name, stop versioning the Blink GC plugin, and remove repackage.sh. BUG=444089 NOPRESUBMIT=true Committed: https://crrev.com/832e529746438a592d8c0a7edd76a8eb9290c8c3 Cr-Commit-Position: refs/heads/master@{#319215}

Patch Set 1 #

Patch Set 2 : Rebase on top of recent update.sh change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -436 lines) Patch
M content/gpu/gpu_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/Edge.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.sh View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 2 chunks +1 line, -4 lines 0 comments Download
M tools/clang/scripts/package.sh View 4 chunks +5 lines, -7 lines 0 comments Download
M tools/clang/scripts/plugin_flags.py View 1 chunk +1 line, -5 lines 0 comments Download
D tools/clang/scripts/repackage.sh View 1 chunk +0 lines, -67 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 9 chunks +17 lines, -352 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
hans
This is the same as previous roll attempt: https://codereview.chromium.org/975503002/, but it targets 231191 to pick ...
5 years, 9 months ago (2015-03-04 05:53:16 UTC) #2
hans
Forgot to mention, the fix mentioned in https://code.google.com/p/chromium/issues/detail?id=444089#c121 was actually in Clang r231156, but that ...
5 years, 9 months ago (2015-03-04 05:54:24 UTC) #3
Nico
lgtm
5 years, 9 months ago (2015-03-04 06:20:09 UTC) #4
hans
Still waiting for V8 roll :/ Tryjob status: - android_rel_tests_recipe fails due to lack of ...
5 years, 9 months ago (2015-03-04 17:34:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980523002/1
5 years, 9 months ago (2015-03-04 21:13:51 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 9 months ago (2015-03-04 21:13:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980523002/20001
5 years, 9 months ago (2015-03-04 21:31:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/47335)
5 years, 9 months ago (2015-03-04 21:53:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980523002/20001
5 years, 9 months ago (2015-03-04 21:54:05 UTC) #16
hans
I've unchecked the cq box until the goma issues are resolved.
5 years, 9 months ago (2015-03-05 00:04:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980523002/20001
5 years, 9 months ago (2015-03-05 01:33:37 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 04:02:22 UTC) #21
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/832e529746438a592d8c0a7edd76a8eb9290c8c3 Cr-Commit-Position: refs/heads/master@{#319215}
5 years, 9 months ago (2015-03-05 04:03:26 UTC) #22
Finnur
This Cl caused the official Linux x64 bot to go red due to the sizes ...
5 years, 9 months ago (2015-03-05 09:54:21 UTC) #23
Nico
It made chrome over 1MB smaller, it's OK if it adds ten kB to nacl_helper ...
5 years, 9 months ago (2015-03-05 14:34:15 UTC) #24
Nico
5 years, 9 months ago (2015-03-05 17:32:54 UTC) #25
Message was sent while issue was closed.
Filed https://code.google.com/p/chromium/issues/detail?id=464417

On Thu, Mar 5, 2015 at 6:34 AM, Nico Weber <thakis@chromium.org> wrote:

> It made chrome over 1MB smaller, it's OK if it adds ten kB to nacl_helper
> :-)
>
> That bot really should call eu-strip before printing the size BTW. The
> size it prints is pretty misleading. If anyone reading this is near a
> keyboard, maybe you can file a bug on me for that?
> On Mar 5, 2015 1:54 AM, <finnur@chromium.org> wrote:
>
>> This Cl caused the official Linux x64 bot to go red due to the sizes
>> check.
>> https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/78934
>>
>>
>> https://codereview.chromium.org/980523002/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698