Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Issue 980473002: Address NewApi lint warnings in src/printing. (Closed)

Created:
5 years, 9 months ago by newt (away)
Modified:
5 years, 9 months ago
Reviewers:
whywhat
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address NewApi lint warnings in src/printing. These are all false positives. We just need to mark several classes with @TargetApi(KitKat) since printing is only used on KitKat+. BUG=411461 Committed: https://crrev.com/04a35e18e9bc841122ce04d26a718cd5d5f8460c Cr-Commit-Position: refs/heads/master@{#319467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +0 lines, -3 lines 0 comments Download
M printing/android/java/src/org/chromium/printing/PrintDocumentAdapterWrapper.java View 2 chunks +3 lines, -0 lines 0 comments Download
M printing/android/java/src/org/chromium/printing/PrintManagerDelegateImpl.java View 2 chunks +4 lines, -1 line 0 comments Download
M printing/android/java/src/org/chromium/printing/PrintingControllerImpl.java View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
5 years, 9 months ago (2015-03-04 01:56:21 UTC) #2
newt (away)
friendly ping?
5 years, 9 months ago (2015-03-05 23:05:12 UTC) #3
whywhat
lgtm +Nicolas FYI
5 years, 9 months ago (2015-03-06 17:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980473002/1
5 years, 9 months ago (2015-03-06 17:27:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 18:36:08 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 18:37:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04a35e18e9bc841122ce04d26a718cd5d5f8460c
Cr-Commit-Position: refs/heads/master@{#319467}

Powered by Google App Engine
This is Rietveld 408576698