Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 980453002: ash::CursorWindowController: handle ui::kCursorNone (Closed)

Created:
5 years, 9 months ago by hshi1
Modified:
5 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash::CursorWindowController: handle ui::kCursorNone Setting cursor type to ui::kCursorNone is treated the same as setting visibility to false. However note that it is necessary to track the last requested cursor visibility separately. BUG=chrome-os-partner:30313 TEST=verify that large cursor disappears in Youtube full-screen mode Committed: https://crrev.com/3f4880805d3a962590c070f70f6fce904a340aa6 Cr-Commit-Position: refs/heads/master@{#319018}

Patch Set 1 #

Patch Set 2 : Need to check |cursor_window_| #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M ash/display/cursor_window_controller.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/display/cursor_window_controller.cc View 1 5 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hshi1
PTAL thanks! This is verified to fix the problem.
5 years, 9 months ago (2015-03-04 00:25:38 UTC) #2
oshima
lgtm
5 years, 9 months ago (2015-03-04 00:56:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980453002/20001
5 years, 9 months ago (2015-03-04 00:57:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 04:25:04 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 04:25:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f4880805d3a962590c070f70f6fce904a340aa6
Cr-Commit-Position: refs/heads/master@{#319018}

Powered by Google App Engine
This is Rietveld 408576698