chrome/browser/sync_file_system/drive_backend/list_changes_task.cc - Issue 98043004: [SyncFS] Run ConflictResolver only when it is needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

Issue 98043004: [SyncFS] Run ConflictResolver only when it is needed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test expectation Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc b/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

index 886db8c77e0f0829c6c15ba8c5147d09419760b6..9a35a93cb345eafeae1f6223cba3351d0b7f77ff 100644

--- a/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

+++ b/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

@@ -86,6 +86,11 @@ void ListChangesTask::DidListChanges(

return;

}

+ if (change_list_.empty()) {

+ callback.Run(SYNC_STATUS_NO_CHANGE_TO_SYNC);

+ return;

+ }

metadata_database()->UpdateByChangeList(

resource_list->largest_changestamp(),

change_list_.Pass(), callback);