Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 98043004: [SyncFS] Run ConflictResolver only when it is needed. (Closed)

Created:
7 years ago by tzik
Modified:
7 years ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, kinuko+watch, tzik
Visibility:
Public.

Description

[SyncFS] Run ConflictResolver only when it is needed. Introduce |should_check_conflict_| flag to SyncEngine and run ConflictResolver only if either: - RemoteToLocalSyncer, - LocalToRemoteSyncer, - ListChangesTask - ConlfictResolver did non-noop task. BUG=240165, 326423 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239211

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix test expectation #

Messages

Total messages: 6 (0 generated)
tzik
PTL
7 years ago (2013-12-06 07:47:22 UTC) #1
kinuko
lgtm (can we verify this does cause infinite loop?)
7 years ago (2013-12-06 08:13:58 UTC) #2
nhiroki
LGTM On 2013/12/06 08:13:58, kinuko wrote: > lgtm (can we verify this does cause infinite ...
7 years ago (2013-12-06 08:56:47 UTC) #3
kinuko
> Verified. This works fine on my local. nice, thanks! To unsubscribe from this group ...
7 years ago (2013-12-06 09:15:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/98043004/40001
7 years ago (2013-12-06 12:03:38 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-06 14:26:41 UTC) #6
Message was sent while issue was closed. 
Change committed as 239211

Powered by Google App Engine
This is Rietveld 408576698