Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 980423002: Organize sky/framework a bit (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Organize sky/framework a bit - Removed out-of-date README.md - Moved fling-curve into the animation directory because it's part of the animation behavior of the system. - Moved view-configuration into the theme directory because it's a collection of constants similar in flavor to the colors and the shadows. Eventually we'll want to make the theme configurable and have these all together will hopefully make that easier. - Moved dom-serializer into tests/resources because it is used only by tests. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46adf9299a6b2c5040e50f5522ddee5c36b22bc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -217 lines) Patch
M sky/examples/fn/widgets/widgets.dart View 1 chunk +1 line, -1 line 0 comments Download
D sky/framework/README.md View 1 chunk +0 lines, -52 lines 0 comments Download
A + sky/framework/animation/fling-curve.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/framework/dom-serializer.sky View 1 chunk +0 lines, -99 lines 0 comments Download
D sky/framework/fling-curve.dart View 1 chunk +0 lines, -55 lines 0 comments Download
M sky/framework/sky-scrollable.sky View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/framework/theme/view-configuration.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/framework/view-configuration.dart View 1 chunk +0 lines, -10 lines 0 comments Download
A + sky/tests/resources/dom-serializer.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/tests/resources/dump-as-markup.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-05 17:54:39 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-05 17:56:03 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-05 17:59:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46adf9299a6b2c5040e50f5522ddee5c36b22bc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698