content/renderer/service_worker/service_worker_script_context.h - Issue 980383004: Relax same-origin policy for ServiceWorker openWindow() in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_script_context.h

Issue 980383004: Relax same-origin policy for ServiceWorker openWindow() in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_messages.h ('k') | content/renderer/service_worker/service_worker_script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_script_context.h

diff --git a/content/renderer/service_worker/service_worker_script_context.h b/content/renderer/service_worker/service_worker_script_context.h

index 4f435dc3cece56fb677ea53393fa979dc7b27bb5..c220dd145499c0860824c247b533b80999b35292 100644

--- a/content/renderer/service_worker/service_worker_script_context.h

+++ b/content/renderer/service_worker/service_worker_script_context.h

@@ -142,7 +142,7 @@ class ServiceWorkerScriptContext {

int request_id, const std::vector<ServiceWorkerClientInfo>& clients);

void OnOpenWindowResponse(int request_id,

const ServiceWorkerClientInfo& client);

- void OnOpenWindowError(int request_id);

+ void OnOpenWindowError(int request_id, const std::string& message);

void OnFocusClientResponse(int request_id,

const ServiceWorkerClientInfo& client);

void OnDidSkipWaiting(int request_id);